kaxil commented on PR #52618: URL: https://github.com/apache/airflow/pull/52618#issuecomment-3022279230
> @kaxil yeah, okay. Thank you. I will add testcode to pr. > > I have a question about task. In this file `providers/microsoft/azure/src/airflow/providers/microsoft/azure/transfers/sftp_to_wasb.py` > > I can not change `from airflow.models import BaseOperator` to `from airflow.providers.microsoft.azure.version_compat import BaseOperator` > > In this case, I have to change test code? > >  I have a problem with this file. imo, we can remove the `dry_run` method in `providers/microsoft/azure/src/airflow/providers/microsoft/azure/transfers/sftp_to_wasb.py`. Or just add something like: ```py def dry_run(self) -> None: if not AIRFLOW_V_3_0_PLUS: raise NotImplementedError("Not implemented for Airflow 3.") super().dry_run() sftp_files: list[SftpFile] = self.get_sftp_files_map() for file in sftp_files: self.log.info( "Process will upload file from (SFTP) %s to wasb://%s as %s", file.sftp_file_path, self.container_name, file.blob_name, ) if self.move_object: self.log.info("Executing delete of %s", file) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
