sjyangkevin opened a new pull request, #52360: URL: https://github.com/apache/airflow/pull/52360
The chage in https://github.com/apache/airflow/pull/51059 broke canary tests in https://github.com/apache/airflow/actions/runs/15910813471/job/44877861492. The PR is reverted through https://github.com/apache/airflow/pull/52312. Create this PR to fix the issue. ### The issue in #51059 First, the refactored `deserialize` take the actual class instead of classname. Therefore, the following test case is modified from `"zi = deserialize("backports.zoneinfo.ZoneInfo", 1, "Asia/Taipei")"` to `zi = deserialize(ZoneInfo, 1, "Asia/Taipei")`. I think the "backports.zoneinfo.ZoneInfo" is a backport of the standard library module `zoneinfo` in Python 3.9, to suppor lower version of Python. In the `airflow-core/src/airflow/serialization/serializers/timezone.py`, the line below is looking for the backport ZoneInfo, instead of the standard library `zoneinfo`. Therefore, when a `ZoneInfo` class is passed into the `deserialize`, the `qualname(cls)` is resolved to "zoneinfo.ZoneInfo" instead of "backports.zoneinfo.ZoneInfo". Therefore, the data will be deserialized through `parse_timezone(data)`, resulting in a different object. Therefore the test case failed. ```python if qualname(cls) == "backports.zoneinfo.ZoneInfo" and isinstance(data, str): ``` ```python def test_timezone_deserialize_zoneinfo(self): from airflow.serialization.serializers.timezone import deserialize zi = deserialize(ZoneInfo, 1, "Asia/Taipei") assert isinstance(zi, ZoneInfo) assert zi.key == "Asia/Taipei" ``` ### Solution To resolve this issue, I updated the if condition to `if cls is ZoneInfo and isinstance(data, str):`. I think the minimum version of Python we support is 3.9. So, "backports.zoneinfo.ZoneInfo" should probably be removed. After making the changes, I ran the following tests and all checks passed. <strike>breeze --python 3.9 testing core-tests --test-type Serialization</strike> <strike>breeze --python 3.9 testing core-tests --test-type Serialization --downgrade-pendulum</strike> breeze --python 3.10 testing core-tests --test-type Serialization breeze --python 3.10 testing core-tests --test-type Serialization --downgrade-pendulum breeze --python 3.11 testing core-tests --test-type Serialization breeze --python 3.11 testing core-tests --test-type Serialization --downgrade-pendulum but I got some container issues when running for 3.12. Will look into the full test results and action accordingly. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
