amoghrajesh commented on code in PR #52777: URL: https://github.com/apache/airflow/pull/52777#discussion_r2184299861
########## providers/alibaba/src/airflow/providers/alibaba/cloud/sensors/oss_key.py: ########## @@ -26,12 +26,8 @@ from airflow.exceptions import AirflowException, AirflowProviderDeprecationWarning from airflow.providers.alibaba.cloud.hooks.oss import OSSHook -from airflow.providers.alibaba.version_compat import AIRFLOW_V_3_0_PLUS - -if AIRFLOW_V_3_0_PLUS: - from airflow.sdk import BaseSensorOperator -else: - from airflow.sensors.base import BaseSensorOperator # type: ignore[no-redef] +from airflow.providers.alibaba.version_compat import BaseSensorOperator +from airflow.utils.context import Context Review Comment: Why move this out of type checking? ########## providers/alibaba/src/airflow/providers/alibaba/cloud/links/maxcompute.py: ########## @@ -18,10 +18,9 @@ from typing import TYPE_CHECKING -from airflow.providers.alibaba.version_compat import AIRFLOW_V_3_0_PLUS +from airflow.providers.alibaba.version_compat import AIRFLOW_V_3_0_PLUS, BaseOperator Review Comment: This doesn't look right, its only for type checking, so should stay where it is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
