stephen-bracken commented on code in PR #52885:
URL: https://github.com/apache/airflow/pull/52885#discussion_r2187200009
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/job.py:
##########
@@ -147,6 +147,12 @@ def create_job(self, job_request_obj: k8s.V1Job) ->
k8s.V1Job:
return job_request_obj
+ def get_or_create_pod(self, pod_request_obj, context):
+ pod = None
+ while pod is None:
Review Comment:
Good point. I was relying on the task timeout to interrupt this, which is a
naive assumption. I can add a static timeout, or add a retry with backoff here
or use the activeDeadlineSeconds from the job spec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
