potiuk commented on code in PR #52931:
URL: https://github.com/apache/airflow/pull/52931#discussion_r2188341667
##########
.github/actions/migration_tests/action.yml:
##########
@@ -24,9 +24,9 @@ runs:
- name: "Test migration file 2 to 3 migration: ${{env.BACKEND}}"
shell: bash
run: |
- breeze shell "${{ env.AIRFLOW_2_CMD }}" --use-airflow-version 2.11.0
--answer y &&
- breeze shell "export
AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${{env.DB_MANGERS}}
- ${{ env.AIRFLOW_3_CMD }}" --no-db-cleanup
+ breeze shell "${AIRFLOW_2_CMD}" --use-airflow-version 2.11.0 --answer
y &&
+ breeze shell "export
AIRFLOW__DATABASE__EXTERNAL_DB_MANAGERS=${DB_MANGERS}
+ ${AIRFLOW_3_CMD}" --no-db-cleanup
env:
Review Comment:
Actually this whole action should likely be refactored - it sounds strange
to use env vars to pass shell commands to breeze shell (and we have breeze run
also recently) - but I wanted to just remove `zizmor` warning first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
