pierrejeambrun commented on code in PR #52437:
URL: https://github.com/apache/airflow/pull/52437#discussion_r2190165929
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -334,6 +336,7 @@ def get_dag_runs(
readable_dag_runs_filter: ReadableDagRunsFilterDep,
session: SessionDep,
dag_bag: DagBagDep,
+ run_id_pattern: Annotated[_SearchParam,
Depends(search_param_factory(DagRun.run_id, "run_id"))],
Review Comment:
```suggestion
run_id_pattern: Annotated[_SearchParam,
Depends(search_param_factory(DagRun.run_id, "run_id_pattern"))],
```
(All search params end up with the `pattern` suffix, this will be the name
of the query parameter)
##########
airflow-core/src/airflow/ui/public/i18n/locales/en/dags.json:
##########
@@ -13,7 +13,8 @@
"active": "Active",
"all": "All",
"paused": "Paused"
- }
+ },
+ "runIdPatternFilter": "Add run_id filter"
Review Comment:
Update the translation "Search Runs"
##########
airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml:
##########
@@ -2041,6 +2041,18 @@ paths:
type: string
default: id
title: Order By
+ - name: run_id
Review Comment:
Just realized that this should be `run_id_pattern` cf comment above and
other search params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
