seanghaeli commented on code in PR #51719:
URL: https://github.com/apache/airflow/pull/51719#discussion_r2190623592
##########
providers/amazon/src/airflow/providers/amazon/aws/triggers/base.py:
##########
@@ -80,7 +80,7 @@ def __init__(
waiter_delay: int,
waiter_max_attempts: int,
waiter_config_overrides: dict[str, Any] | None = None,
- aws_conn_id: str | None,
+ aws_conn_id: str | None = "aws_default",
Review Comment:
Prompted by @eladkal 's comment:
> This isn't consistent with what was discussed on #51196 is it?
In which the custom connection ID is passed through kwargs through the
superclass. The AwsBaseOperator initializes the parameter as: `"aws_conn_id:
str | None = "aws_default"`, whereas the AwsBaseWaiterTrigger does it like:
`aws_conn_id: str | None`.
Let me know your thoughts. If you agree with the change, maybe the better
thing to do is make it a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
