o-nikolas commented on PR #53000: URL: https://github.com/apache/airflow/pull/53000#issuecomment-3049661515
> @o-nikolas if you don't mind, let me know what you think I like this change. All the sets that we have for specific terminal states (I think it's just `success` and `failure` states at the moment) should definitely sum up to the full set of terminal states. This makes the set math you're trying to do in your original PR much cleaner, future proof and not hardcoded to specific sets which is all great stuff. Only concern I'd have is what you mention, the changes propagating in ways we don't expect, but I don't think this is insurmountable and I'd be interested to see hear how many tests failed because of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
