jscheffl commented on code in PR #53024:
URL: https://github.com/apache/airflow/pull/53024#discussion_r2193466255
##########
airflow-core/src/airflow/utils/log/file_task_handler.py:
##########
@@ -482,6 +482,15 @@ def read(
"""
if try_number is None:
try_number = task_instance.try_number
+
+ if task_instance.state == TaskInstanceState.SKIPPED:
Review Comment:
@pierrejeambrun / @kaxil
Unfortunately this handling as it is now causes another bug as regression.
It is "correct" if a short circuit or SkipMixIn really skipped the execution
and the try_number is == 0 ... but there are also the cases where a task is
actually executed and returns a AirflowSkipPException e.g. via s skip return
code.
Example task:
Then logs are actually existing and task has try_number >0 but logs are not
showing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
