gopidesupavan commented on code in PR #53047:
URL: https://github.com/apache/airflow/pull/53047#discussion_r2193491172


##########
task-sdk/src/airflow/sdk/execution_time/secrets_masker.py:
##########
@@ -154,7 +151,8 @@ def _get_v1_env_var_type() -> type:
     return V1EnvVar
 
 
-def _is_v1_env_var(v: Any) -> TypeGuard[V1EnvVar]:

Review Comment:
   ```
   task-sdk/src/airflow/sdk/execution_time/secrets_masker.py: error: INTERNAL 
ERROR -- Please try using mypy master on GitHub:
   
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
   Please report a bug at https://github.com/python/mypy/issues
   version: 1.16.1
   Traceback (most recent call last):
     File "/usr/local/bin/mypy", line 10, in <module>
       sys.exit(console_entry())
     File "mypy/build.py", line 2062, in wrap_context
     File "mypy/build.py", line 2391, in finish_passes
     File "mypy/build.py", line 2424, in _patch_indirect_dependencies
     File "mypy/indirection.py", line 35, in find_modules
     File "mypy/indirection.py", line 46, in _visit
     File "mypy/types.py", line 276, in accept
   RuntimeError: ('Not implemented', <class 'mypy.types.TypeGuardedType'>)
   task-sdk/src/airflow/sdk/execution_time/secrets_masker.py: : note: use --pdb 
to drop into pdb
   ```
   Will open issue with mypy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to