jason810496 commented on code in PR #53080:
URL: https://github.com/apache/airflow/pull/53080#discussion_r2194615015
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/ecs.py:
##########
@@ -29,6 +33,9 @@
def should_retry(exception: Exception):
"""Check if exception is related to ECS resource quota (CPU, MEM)."""
+ if isinstance(exception, EcsCannotPullContainerError):
+ return False
+
if isinstance(exception, EcsOperatorError):
Review Comment:
IMO, let the `EcsCannotPullContainerError` error fail fast instead of
retrying should be fine right ?
Based on the [Documentation - CannotPullContainer task errors in Amazon
ECS](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_cannot_pull_image.html),
it's more like configuration error from user instead of system instability.
cc @o-nikolas , @eladkal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
