kaxil commented on code in PR #53020:
URL: https://github.com/apache/airflow/pull/53020#discussion_r2194788728
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -1402,6 +1406,7 @@ def mock_send_side_effect(*args, **kwargs):
mock_supervisor_comms.send.side_effect = mock_send_side_effect
run(runtime_ti, context=runtime_ti.get_template_context(),
log=mock.MagicMock())
+ spy_agency.assert_spy_called_with(deserialize, ser_value)
Review Comment:
I don't specifically like this test. It ends up creating 254 tests because
of cartesian product (unrelated to changes in this PR).
For the change specific to this PR, a better test would be to check and
assert value I think instead of checking `deserialize` is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
