ashb commented on code in PR #53058:
URL: https://github.com/apache/airflow/pull/53058#discussion_r2194800569
##########
airflow-core/src/airflow/dag_processing/processor.py:
##########
@@ -238,6 +238,66 @@ def _execute_dag_callbacks(dagbag: DagBag, request:
DagCallbackRequest, log: Fil
Stats.incr("dag.callback_exceptions", tags={"dag_id":
request.dag_id})
+def _execute_task_callbacks(dagbag: DagBag, request: TaskCallbackRequest, log:
FilteringBoundLogger) -> None:
+ if not request.is_failure_callback:
+ log.warning(
+ "Task callback requested but is not a failure callback",
+ dag_id=request.ti.dag_id,
+ task_id=request.ti.task_id,
+ run_id=request.ti.run_id,
+ )
+ return
+
+ dag = dagbag.dags[request.ti.dag_id]
+ task = dag.get_task(request.ti.task_id)
+
+ if request.task_callback_type is TaskInstanceState.UP_FOR_RETRY:
+ callbacks = task.on_retry_callback
+ else:
+ callbacks = task.on_failure_callback
+
+ if not callbacks:
+ log.warning(
+ "Callback requested but no callback found",
+ dag_id=request.ti.dag_id,
+ task_id=request.ti.task_id,
+ run_id=request.ti.run_id,
Review Comment:
```suggestion
dag_id=request.ti.dag_id,
task_id=request.ti.task_id,
run_id=request.ti.run_id,
ti_id=request.ti.id,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
