Nataneljpwd commented on code in PR #52700:
URL: https://github.com/apache/airflow/pull/52700#discussion_r2196840687
##########
providers/sftp/src/airflow/providers/sftp/hooks/sftp.py:
##########
@@ -86,10 +93,12 @@ def __init__(
self,
ssh_conn_id: str | None = "sftp_default",
host_proxy_cmd: str | None = None,
+ managed_conn: bool = True,
*args,
**kwargs,
) -> None:
self.conn: SFTPClient | None = None
+ self.managed_conn = managed_conn
Review Comment:
A change for all functions is required as it was implemented with the
managed conn, and making it not create another connection just breaks the api,
but I think I can do something with magic methods to make the code a whole lot
shorter, I will try and publish it when it's ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
