nrnavaneet commented on PR #53138:
URL: https://github.com/apache/airflow/pull/53138#issuecomment-3058043295
Thanks for the feedback! I’ve removed the redundant checks.
• Instead of checking if "schema" in query_results and later
re-fetching it with query_results.get("schema"), I now directly retrieve the
schema once and pass it to _format_schema_for_description.
• The function itself (_format_schema_for_description) handles
None, type mismatches, and missing fields, so upstream validation is no longer
necessary.
This simplifies the logic and ensures the single-responsibility principle is
followed.
Let me know if you’d like me to adjust further!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
