Lee-W commented on PR #53057:
URL: https://github.com/apache/airflow/pull/53057#issuecomment-3060384615
Hey @sunank200 , the main AIP-90 branch has been merged. Would be great if
you could rebase from the main branch again 🙂 Also, discussed with @guan404ming
, the frontend can't get ti_id directly. Thus, we change the endpoints to the
following.
1. `GET /api/v2/hitl-details/{dag_id}/{dag_run_id}/{task_id}`: Get a
HITLDetail for a specific task instance
2. `GET /api/v2/hitl-details/{dag_id}/{dag_run_id}/{task_id}/{map_index}`:
Get a HITLDetail for a specific mapped task instance
3. `PATCH /api/v2/hitl-details/{dag_id}/{dag_run_id}/{task_id}`: write the
response content part back to an existing HITLDetail for a specific task
instance
4. `PATCH /api/v2/hitl-details/{dag_id}/{dag_run_id}/{task_id}/{map_index}`:
write the response content part back to an existing HITLDetail for a specific
mapped task instance
We'll need your help to change the share link endpoint to something like
* /api/v2/`hitl-details-share-link`/{dag_id}/{dag_run_id}/{task_id}
*
/api/v2/`hitl-details-share-link`/{dag_id}/{dag_run_id}/{task_id}/{map_index}
Add a `/shared` at the end of the endpoint won't work due to `{map_index}`.
I thought of
`/api/v2/hitl-details/dagId/{dag_id}/dagRunId/{dag_run_id}/taskId/{task_id}/mapIndex/{map_index}`,
which makes appending works. However, I decided not to do it as it makes the
URL too lengthy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
