BasPH commented on a change in pull request #6489: [AIRFLOW-3959] add UI filter
with DAGs tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r341838278
##########
File path: airflow/models/dag.py
##########
@@ -1384,7 +1390,8 @@ def sync_to_db(self, owner=None, sync_time=None,
session=None):
orm_dag.default_view = self._default_view
orm_dag.description = self.description
orm_dag.schedule_interval = self.schedule_interval
- session.merge(orm_dag)
+ orm_dag.tags = [self.get_dagtag(name, session=session) for name in
set(self.tags)]
Review comment:
To avoid multiple calls to the DB, could we add a convenience method
`get_dagtags` for supplying a list of tags? Or change `get_dagtag` to accept a
list of strings besides a single string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
