potiuk commented on code in PR #53170: URL: https://github.com/apache/airflow/pull/53170#discussion_r2200328116
########## providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/version_compat.py: ########## @@ -36,10 +36,12 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]: AIRFLOW_V_3_1_PLUS = get_base_airflow_version_tuple() >= (3, 1, 0) if AIRFLOW_V_3_1_PLUS: + from airflow.models.xcom import XCOM_RETURN_KEY Review Comment: > Also this reminds me- the airflow version check in providers needs to go soon too - we ideally want to "duck type" off what we can I the sdk (i.e. try import except) Question: are we going to have task-sdk installable also in Airflow 2 or is it going to be optional dependency of providers? Currently it's not that's why have all the "ifs" and they have to be part of provider's code - so such a version check in sdk will only be really possible to remove from providers if task-sdk is also installable on Airflow 2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
