eladkal commented on code in PR #53182:
URL: https://github.com/apache/airflow/pull/53182#discussion_r2200985441
##########
providers/google/src/airflow/providers/google/cloud/operators/vertex_ai/ray.py:
##########
@@ -93,8 +93,10 @@ class CreateRayClusterOperator(RayBaseOperator):
:param location: Required. The ID of the Google Cloud region that the
service belongs to.
:param head_node_type: The head node resource. Resources.node_count must
be 1. If not set, default
value of Resources() class will be used.
- :param python_version: Python version for the ray cluster.
- :param ray_version: Ray version for the ray cluster. Default is 2.33.0.
+ :param python_version: Required. Python version for the ray cluster.
+ :param ray_version: Required. Ray version for the ray cluster.
+ Currently only 3 version are available: 2.9.3, 2.33, 2.42. For more
information please refer to
+ https://github.com/googleapis/python-aiplatform/blob/main/setup.py#L101
Review Comment:
Please lets not do that listing.
I don't want us to manually support and update doc string per any change
google makes.
also the link is not guaranteed to work one change of code line and it's a
wrong link
If we want to have a link it should be to a google user facing doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
