Copilot commented on code in PR #53196:
URL: https://github.com/apache/airflow/pull/53196#discussion_r2201087288
##########
airflow-core/src/airflow/utils/deprecation_tools.py:
##########
@@ -42,15 +42,26 @@ def getattr_with_deprecation(
:return:
"""
target_class_full_name = imports.get(name)
+
+ # Handle wildcard pattern "*" - redirect all attributes to target module
+ # Skip Python special attributes (dunder attributes) as they shouldn't be
redirected
+ if not target_class_full_name and "*" in imports and not
name.startswith("__"):
Review Comment:
[nitpick] To only skip true dunder attributes, consider checking both
leading and trailing underscores, e.g.: `if not target_class_full_name and '*'
in imports and not (name.startswith('__') and name.endswith('__')):`
```suggestion
if not target_class_full_name and "*" in imports and not
(name.startswith("__") and name.endswith("__")):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
