dominikhei commented on PR #51692:
URL: https://github.com/apache/airflow/pull/51692#issuecomment-3063942760
> Ah okay. It's quite an edge case so I can't find a way to reproduce, I
think your fix and tests look good. But I have one more thing I'd like to
clarify:
>
> The original PR is concerned with situations where the API response looks
like the following:
>
> ```
> {
> "tasks": [
> {
> "attachments": [],
> "capacityProviderName":
"Infra-ECS-Cluster-***-EC2CapacityProvider-***",
> "clusterArn": "arn:aws:ecs:***:***:cluster/***",
> "containers": [],
> "cpu": "1024",
> "createdAt": datetime.datetime(
> 2025, 6, 5, 8, 55, 51, 381000, tzinfo=tzlocal()
> ),
> "desiredStatus": "RUNNING",
> "enableExecuteCommand": False,
> "group": "family:***",
> "lastStatus": "PROVISIONING",
> "launchType": "EC2",
> "memory": "4096",
> "overrides": {
> "containerOverrides": [{ ... }],
> "inferenceAcceleratorOverrides": [],
> },
> "startedBy": "airflow",
> "tags": [],
> "taskArn": "arn:aws:ecs:***:***:task/***/***",
> "taskDefinitionArn": "arn:aws:ecs:***:***:task-definition/***",
> "version": 1,
> }
> ],
> "failures": [],
> "ResponseMetadata": {
> "RequestId": "***",
> "HTTPStatusCode": 200,
> "HTTPHeaders": {
> "x-amzn-requestid": "***",
> "content-type": "application/x-amz-json-1.1",
> "content-length": "1360",
> "date": "Thu, 05 Jun 2025 08:55:51 GMT",
> },
> "RetryAttempts": 0,
> },
> }
> ```
>
> where the response has an empty array in the 'containers' field.
>
> But in your test case, there is a populated containers field, it just
doesn't have a name. Has the scope of the issue changed, or should you also be
testing the case where the whole 'containers' field is empty?
Good catch! Will adjust the test case, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
