potiuk commented on code in PR #53149: URL: https://github.com/apache/airflow/pull/53149#discussion_r2202378742
########## task-sdk/src/airflow/sdk/_vendor/.gitignore: ########## @@ -0,0 +1 @@ +*/*.py Review Comment: It will look better in the imports as well - reflecting it's real use, and if we go for functionality split that will be way more logical: ``` from airflow.sdk._shared.logging import logger ``` ########## task-sdk/src/airflow/sdk/_vendor/.gitignore: ########## @@ -0,0 +1 @@ +*/*.py Review Comment: It will look better in the imports as well - reflecting it's real use, and if we go for functionality split that will be way more logical: ```python from airflow.sdk._shared.logging import logger ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
