Re: [PR] [v3-0-test] Resolve OOM When Reading Large Logs in Webserver [airflow]

[via GitHub]

jason810496 commented on PR #53167:
URL: https://github.com/apache/airflow/pull/53167#issuecomment-3065543055

   > > @jason810496 is backport something went wrong? could see many files
   > 
   > Fixed it
   
   Thanks @kaxil!
   I just check this backport PR modify the same files by the following script.
   ```bash
   REPO=apache/airflow
   PR1=53167
   PR2=49470
   
   # Get the list of changed files from each PR
   FILES_PR1=$(gh pr view "$PR1" --repo "$REPO" --json files --jq 
'.files[].path' | sort)
   FILES_PR2=$(gh pr view "$PR2" --repo "$REPO" --json files --jq 
'.files[].path' | sort)
   
   TMP1=$(mktemp)
   TMP2=$(mktemp)
   
   echo "$FILES_PR1" > "$TMP1"
   echo "$FILES_PR2" > "$TMP2"
   
   # Compare the two sorted lists
   if cmp -s "$TMP1" "$TMP2"; then
       echo "✅ PR #$PR1 and PR #$PR2 modify the exact same set of files."
   else
       echo "❌ PR #$PR1 and PR #$PR2 modify different sets of files."
   
       echo -e "\n📄 Files only in PR #$PR1:"
       comm -23 "$TMP1" "$TMP2"
   
       echo -e "\n📄 Files only in PR #$PR2:"
       comm -13 "$TMP1" "$TMP2"
   fi
   
   rm -f "$TMP1" "$TMP2"
   ```
   
   I have also test the behavior using `breeze k8s` with the following setup, 
the first 2 work well 
   
   1. kubernetes executor
   2. celery executor
   3.  kubernetes executor + remote logging with Google Cloud Storage
   4. celery executor + remote logging with Google Cloud Storage
   
   but the setup** with remote logging with Google Cloud Storage result in 
errors**.
   
   I just found the root cause and will raise another PR to fix it, mark this 
PR to draft to void mislead merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org