jscheffl commented on code in PR #53252:
URL: https://github.com/apache/airflow/pull/53252#discussion_r2202912638
##########
providers/vertica/src/airflow/providers/vertica/hooks/vertica.py:
##########
@@ -67,7 +67,7 @@ class VerticaHook(DbApiHook):
def get_conn(self) -> connect:
"""Return vertica connection object."""
- conn = self.get_connection(self.vertica_conn_id) # type: ignore
+ conn = self.get_connection(self.vertica_conn_id)
Review Comment:
@potiuk / @gopidesupavan I am scratching my head and taking a look to the
code.... as well as to the history. The field `vertica_conn_id` actually is not
existing and seems invalid - for thi sis actually broken and can not be used.
`type ignore` is just masking the problem currently.
I am not sure what is "right", I assume an `__init__()` is missing which
defined the field (but this would be breaking for all users to define this in
constructor) or it would need to use `conn_name_attr`.
```suggestion
conn = self.get_connection(self.conn_name_attr)
```
```suggestion
conn = self.get_connection(self.vertica_conn_id)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
