[
https://issues.apache.org/jira/browse/AIRFLOW-5704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966494#comment-16966494
]
ASF GitHub Bot commented on AIRFLOW-5704:
-----------------------------------------
potiuk commented on pull request #6496: [AIRFLOW-5704] Improve Kind Kubernetes
scripts for local testing. Depends on [AIRFLOW-5826] [AIRFLOW-5827]
[AIRFLOW-5830] [AIRFLOW-5829]
URL: https://github.com/apache/airflow/pull/6496
NOTE TO REVIEWER. This PR depends on #6495 #6490 #6493 #6494. Please review
only last commit.
* Fixed problem that Kubernetes tests were testing latest master
rather than what came from the local sources.
* Moved Kubernetes scripts to 'in_container' dir where they belong now
* Kubernetes tests are now better suited for running locally
* Kubernetes cluster is not deleted until environment is stopped
* Kubernetes image is built outside of the container and passed as .tar
* Kubectl version name is corrected in the Dockerfile
* Kubernetes Version can be used to select Kubernetes versio
* Running kubernetes scripts is now easy in Breeze
* Instructions on how to run Kubernetes tests are updated
* Better flags in Breeze are used to run Kubernetes environment/tests
* The old "bare" environment is replaced by --no-deps switch
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5704
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Docker scripts for kind kubernetes tests can be improved
> --------------------------------------------------------
>
> Key: AIRFLOW-5704
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5704
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: ci
> Affects Versions: 2.0.0
> Reporter: Jarek Potiuk
> Assignee: Jarek Potiuk
> Priority: Major
>
> The docker CI image for kind tests can be improved
>
> * Kubernetes Version and all the installation of docker + kubectl + kind can
> be added back
> * Running kubernetes scripts should be possible from within breeze without
> special "kubernetes" environment
> * --env breeze switch should be removed
> * "bare" environment should be replaced by --no-deps switch
> * ENV variable should disappear
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
