sunank200 commented on code in PR #53189:
URL: https://github.com/apache/airflow/pull/53189#discussion_r2208297261
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -75,10 +85,21 @@ def _update_hitl_detail(
dag_run_id: str,
task_id: str,
update_hitl_detail_payload: UpdateHITLDetailPayload,
- user: GetUserDep,
+ user: GetUserDep | None,
Review Comment:
Added a comment in docstring as well
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -75,10 +85,21 @@ def _update_hitl_detail(
dag_run_id: str,
task_id: str,
update_hitl_detail_payload: UpdateHITLDetailPayload,
- user: GetUserDep,
+ user: GetUserDep | None,
session: SessionDep,
map_index: int | None = None,
) -> HITLDetailResponse:
+ """
+ Update a Human-in-the-loop detail.
+
+ :param dag_id: DAG ID
Review Comment:
Changed it.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -260,7 +281,7 @@ def get_hitl_details(
readable_ti_filter: ReadableTIFilterDep,
session: SessionDep,
) -> HITLDetailCollection:
- """Get Human-in-the-loop details."""
+ """Get all Human-in-the-loop details."""
Review Comment:
Changed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
