jscheffl commented on code in PR #53433:
URL: https://github.com/apache/airflow/pull/53433#discussion_r2211341781


##########
providers/sqlite/src/airflow/providers/sqlite/hooks/sqlite.py:
##########
@@ -47,8 +47,6 @@ def get_conn(self) -> sqlite3.dbapi2.Connection:
     def get_uri(self) -> str:
         """Override DbApiHook get_uri method for get_sqlalchemy_engine()."""
         airflow_conn = self.get_connection(self.get_conn_id())
-        if airflow_conn.conn_type is None:
-            airflow_conn.conn_type = self.conn_type

Review Comment:
   Rationale for removal: According to type definition of "Connection" the 
`conn_type` is not nullable. If somebody loads a connection without it is for 
sure invalid data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to