gopidesupavan commented on PR #53434: URL: https://github.com/apache/airflow/pull/53434#issuecomment-3081065830
> As for the future---- I still I would consider a PR makes sense to (1) add a type:ignore to suppress the warnign and (2) also add a comment why this is needed -for the future you/me that wants to fix the code. > > Can you also tell me how the code is executed that the first return is not hit? Will then a driver raise an exception which is catched and then the second return is kicking-in? yeah will reopen this update type ignore. we have this custom suppression logic `with suppress_and_warn(jaydebeapi.Error, jpype.JException)` its getting suppressed when error raises and then the false getting returned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
