[
https://issues.apache.org/jira/browse/AIRFLOW-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967003#comment-16967003
]
ASF GitHub Bot commented on AIRFLOW-5828:
-----------------------------------------
potiuk commented on pull request #6500: [AIRFLOW-5828] Vastly simplify build
scripts Switch to Debian buster image. Depends on [AIRFLOW-5830] [AIRFLOW-5829]
[AIRFLOW-5704] [AIRFLOW-5842]
URL: https://github.com/apache/airflow/pull/6500
NOTE FOR REVIEWER: This change depends on #6494 #6495 #6373 #6499. Please
check only last commit.
* Generic Build sript logic is now moved from hooks/build to scripts/ci
* All the scripts are split to smaller functions
* The functions are now grouped in scripts/ci/utils/*.sh by build stage
* The logic of builds is vastly simplified - it's sequence of functions
* The "common" directory is moved to script/ci/utils/
* The DockerHub build-specific logic is now moved to hooks/build
* You can see the progress of build while pre-commit builds (spinner)
* You can see the log file where progress of the build is displayed
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5828
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Build scripts should be simplified
> ----------------------------------
>
> Key: AIRFLOW-5828
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5828
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: ci
> Affects Versions: 2.0.0
> Reporter: Jarek Potiuk
> Priority: Major
>
> Builds scripts are unncessarily complex because of hooks/builds were
> initially done for Dockerhub only and then adapted to Travis CI. We can
> simplify the scripts by moving everything to the scripts/ci to separate bash
> functions and make hooks/build use the functions.
> Separating everything to functions will make the scripts easy to maintain as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
