tirkarthi commented on code in PR #53438:
URL: https://github.com/apache/airflow/pull/53438#discussion_r2213519566
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridTI.tsx:
##########
@@ -78,23 +116,51 @@ const Instance = ({ dagId, isGroup, isMapped, runId,
search, state, taskId }: Pr
>
<Badge
borderRadius={4}
- colorPalette={state === null ? "none" : state}
+ colorPalette={instance.state ?? "none"}
height="14px"
minH={0}
- opacity={state === "success" ? 0.6 : 1}
+ onMouseEnter={onBadgeMouseEnter}
+ onMouseLeave={onBadgeMouseLeave}
p={0}
+ position="relative"
variant="solid"
width="14px"
>
- {state === undefined ? undefined : (
- <StateIcon
- size={10}
- state={state}
- style={{
- marginLeft: "2px",
- }}
- />
- )}
+ <StateIcon
+ size={10}
+ state={instance.state}
+ style={{
+ marginLeft: "2px",
+ }}
+ />
+ <chakra.span
+ bg="bg.inverted"
+ borderRadius={2}
+ bottom={0}
+ color="fg.inverted"
+ id="tooltip"
+ p={2}
+ position="absolute"
+ right={0}
+ visibility="hidden"
+ zIndex={1}
+ >
+ {translate("taskId")}: {taskId}
+ <br />
+ {translate("state")}: {instance.state}
+ {instance.min_start_date !== null && (
+ <>
+ <br />
+ {translate("startDate")}: <Time
datetime={instance.min_start_date} />
Review Comment:
It's more of a backend API implementation detail and wanted to note it but
not act as a blocker for the PR. Resolving my comment to discuss as a separate
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
