sunank200 commented on code in PR #53393:
URL: https://github.com/apache/airflow/pull/53393#discussion_r2215706065
##########
airflow-core/src/airflow/utils/__init__.py:
##########
@@ -46,5 +46,11 @@ def __getattr__(name: str):
"xcom": {
"XCOM_RETURN_KEY": "airflow.models.xcom.XCOM_RETURN_KEY",
},
+ "weight_rule": {
+ "WeightRule": "airflow.sdk.definitions.weight_rule.WeightRule",
Review Comment:
For things which are shared between core and sdk like weight_rule, I have
duplicated it in both places and added a TODO to remove it once airflow-shared
is available. Or should i leave it for now?
##########
airflow-core/src/airflow/utils/__init__.py:
##########
@@ -46,5 +46,11 @@ def __getattr__(name: str):
"xcom": {
"XCOM_RETURN_KEY": "airflow.models.xcom.XCOM_RETURN_KEY",
},
+ "weight_rule": {
+ "WeightRule": "airflow.sdk.definitions.weight_rule.WeightRule",
Review Comment:
So this would make more sense to just move to airflow-shared i think
##########
airflow-core/src/airflow/utils/__init__.py:
##########
@@ -46,5 +46,11 @@ def __getattr__(name: str):
"xcom": {
"XCOM_RETURN_KEY": "airflow.models.xcom.XCOM_RETURN_KEY",
},
+ "weight_rule": {
+ "WeightRule": "airflow.sdk.definitions.weight_rule.WeightRule",
+ "db_safe_priority":
"airflow.sdk.definitions.weight_rule.db_safe_priority",
+ "DB_SAFE_MINIMUM":
"airflow.sdk.definitions.weight_rule.DB_SAFE_MINIMUM",
+ "DB_SAFE_MAXIMUM":
"airflow.sdk.definitions.weight_rule.DB_SAFE_MAXIMUM",
Review Comment:
Moved it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
