potiuk commented on PR #53149: URL: https://github.com/apache/airflow/pull/53149#issuecomment-3090383843
Also an example where I put this "low-cyclomatic" complexity in practice.... Breeze. I have not raised it before but practically the whole https://github.com/apache/airflow/tree/main/dev/breeze/src/airflow_breeze/utils is build around those concepts - where each of the "shared modules" is practically independent from the others. There are a few exceptions - global constants and likely a handful of small classes that **might** create diamond-shaped dependencies, but it's mostly because I had no limits there and I did not have to constrain myself and did not have any "check" for cyclomatic complexity. But I think it would have been quite easy to make it fully non-diamond shaped - except constants. I think we have to find a solution for shared constants and I will think about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
