choo121600 commented on issue #53324: URL: https://github.com/apache/airflow/issues/53324#issuecomment-3091933547
Thank you for the detailed explanation! I now understand the overall design where a separate `pre-commit` hook checks for completion. The reason I opened this issue is because I personally found the script's output confusing. When I saw the "All translations are complete and consistent!" message along with a 100% progress rate, even with many `TODO`s remaining, I mistakenly assumed that the translation was fully complete. <img width="1023" height="1171" alt="Image" src="https://github.com/user-attachments/assets/e6934dc5-1a6a-42b0-8e8a-60098677a3a4"; /> Thinking that others might experience the same confusion I did, I'd like to propose solving this by distinguishing between two key metrics: * **Coverage**: This would confirm that the key is synchronized between the en and the target language. This is primarily a **developer's sync task**. * **Completion**: This would measure the actual translation progress by checking for keys that are no longer marked as `TODO`. This is a **translator's task**. <img width="1030" height="683" alt="Image" src="https://github.com/user-attachments/assets/819b1242-3fa6-4c8b-b70a-c98e0f110796"; /> <img width="1032" height="1119" alt="Image" src="https://github.com/user-attachments/assets/938fba6f-516c-410f-8ec8-d8312e54a966"; /> I would love to hear your thoughts on this proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
