potiuk commented on PR #53529: URL: https://github.com/apache/airflow/pull/53529#issuecomment-3092495339
> Speaking more broadly - I think there's an integration test gap here. I couldn’t find any existing integration test that boots Airflow with each remote‑log provider and hits /config. Providers do have isolated unit tests, but nothing that covers the cross‑boundary behaviour we’re touching here Actually this is because of lack of ABCData meta-class in definition of ExternalLoggingMixin. All the "External" handlers derive from it and since ExternalLoggingMixin does not have ABCData as Metaclass, so you can instantiate the derived classes even if the methods are declared as abstract methods: <img width="803" height="736" alt="Screenshot 2025-07-19 at 20 13 04" src="https://github.com/user-attachments/assets/8c1d2abb-36d9-42ae-87a4-52af6857fe9a"; /> @Owen-CH-Leung -> Maybe you can fix it as part of that PR (that would be equivalent of tests). What should happen when you add the metaclass, regular unit tests should fail for all the log handlers that have missing abstract methods because it will be impossible to instantiate them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
