Vasu-Madaan commented on code in PR #53477:
URL: https://github.com/apache/airflow/pull/53477#discussion_r2217564831
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -1132,7 +1132,10 @@ def _build_find_pod_label_selector(self, context:
Context | None = None, *, excl
**self.labels,
**self._get_ti_pod_labels(context, include_try_number=False),
}
- label_strings = [f"{label_id}={label}" for label_id, label in
sorted(labels.items())]
+ label_strings = [
+ f"{label_id}={str(label) if label is not None else ''}"
+ for label_id, label in sorted(labels.items())
+ ]
Review Comment:
Agreed, but I’ve seen use cases where the value of a label is determined
based on the output of another function, and in Python, None is a common way to
represent the absence of a value. That might be why allowing None to be passed
makes sense, as long as it’s properly handled by the provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
