amoghrajesh commented on code in PR #52156:
URL: https://github.com/apache/airflow/pull/52156#discussion_r2218306289


##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -625,6 +631,7 @@ def start_airflow(
         force_build=force_build,
         forward_credentials=forward_credentials,
         github_repository=github_repository,
+        go_worker=go_worker,

Review Comment:
   We should probably add one check though, we should validate if the executor 
is `CeleryExecutor` or fail early



##########
dev/breeze/src/airflow_breeze/commands/common_options.py:
##########
@@ -525,3 +525,10 @@ def _normalize_platform(ctx: click.core.Context, param: 
click.core.Option, value
     callback=_normalize_platform,
     type=BetterChoice(SINGLE_PLATFORMS),
 )
+
+option_go_worker = click.option(

Review Comment:
   Set default to false?



##########
scripts/in_container/bin/run_tmux:
##########
@@ -123,6 +123,17 @@ if [[ ${STANDALONE_DAG_PROCESSOR} == "true" ]]; then
     tmux send-keys 'airflow dag-processor' C-m
 fi
 
+if [[ ${STANDALONE_DAG_PROCESSOR} == "true" ]]; then
+    tmux select-pane -t 2
+    tmux split-window -h
+    tmux set-option -p @airflow_component "Go worker"
+    tmux send-keys "cd go-sdk" C-m
+    tmux send-keys "go run ./example/main.go run \

Review Comment:
   Yeah we need it. The second run it the "run" subcommand for go workers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to