potiuk commented on code in PR #53506:
URL: https://github.com/apache/airflow/pull/53506#discussion_r2218852569


##########
task-sdk/pyproject.toml:
##########
@@ -65,6 +65,13 @@ dependencies = [
     "requests>=2.31.0,<3",
     "types-requests>=2.31.0",
     "tenacity>=8.3.0",
+    # Beginning of automatically included dependencies from shared airflow 
packages

Review Comment:
   > I'm guessing you added something in pre-commit to manage this, but I don't 
see it in this PR?
   
   Yeah. That's the one part that is **not** implemented yet - I wrote about it 
at the beginning of the description :). ... It will require a bit of work to 
make it right (you need to detect who uses what and then sync the deps - 
including likely both "required", "dev" and "optional" deps (that would be best 
for cases like for example "serialization" having optional "pandas" requirement 
for example if we decide to leave the pandas code in serialization rather than 
implement some plugin mechanism for serialization, so I did not want to 
implement it **yet** before we agree that it's the way to go.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to