jason810496 commented on code in PR #53598:
URL: https://github.com/apache/airflow/pull/53598#discussion_r2219657408
##########
kubernetes-tests/tests/kubernetes_tests/test_kubernetes_pod_operator.py:
##########
@@ -1466,6 +1466,74 @@ def test_init_container_logs_filtered(self,
mock_get_connection):
< calls_args.find(marker_from_main_container)
)
+ @pytest.mark.asyncio
Review Comment:
How about combine these 3 test scenarios with 1 test method with
`pytest.mark.parameterize` ?
Since the only difference among the tests are the `log_prefix`,
`log_formatter` setup and expected value in assertion.
Just personal preference, no strong opinion for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
