ramitkataria commented on code in PR #53201:
URL: https://github.com/apache/airflow/pull/53201#discussion_r2220580505
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -589,7 +589,7 @@ def update_triggers(self, requested_trigger_ids: set[int]):
cancel_trigger_ids = self.running_triggers - requested_trigger_ids
# Bulk-fetch new trigger records
new_triggers = Trigger.bulk_fetch(new_trigger_ids)
- triggers_with_assets = Trigger.fetch_trigger_ids_with_asset()
+ trigger_ids_with_non_task_associations =
Trigger.fetch_trigger_ids_with_non_task_associations()
Review Comment:
I'm interested in getting this merged asap so that the next PRs for
deadlines can be created. If you still strongly believe that we should call it
`non_task_triggers`, I'm happy to make that change in a later PR but I'll
resolve for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
