This is an automated email from the ASF dual-hosted git repository.
amoghdesai pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 747a3e703aa Add deprecation notice for using Connection from models
(#53594)
747a3e703aa is described below
commit 747a3e703aa46fb41297d052060122575a59e766
Author: Amogh Desai <[email protected]>
AuthorDate: Tue Jul 22 11:57:12 2025 +0530
Add deprecation notice for using Connection from models (#53594)
---
airflow-core/src/airflow/models/connection.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/airflow-core/src/airflow/models/connection.py
b/airflow-core/src/airflow/models/connection.py
index 5548f7726ec..782acbf4140 100644
--- a/airflow-core/src/airflow/models/connection.py
+++ b/airflow-core/src/airflow/models/connection.py
@@ -21,6 +21,7 @@ import json
import logging
import re
import sys
+import warnings
from contextlib import suppress
from json import JSONDecodeError
from typing import Any
@@ -473,10 +474,15 @@ class Connection(Base, LoggingMixin):
# If this is set it means are in some kind of execution context (Task,
Dag Parse or Triggerer perhaps)
# and should use the Task SDK API server path
if hasattr(sys.modules.get("airflow.sdk.execution_time.task_runner"),
"SUPERVISOR_COMMS"):
- # TODO: AIP 72: Add deprecation here once we move this module to
task sdk.
from airflow.sdk import Connection as TaskSDKConnection
from airflow.sdk.exceptions import AirflowRuntimeError, ErrorType
+ warnings.warn(
+ "Using Connection.get_connection_from_secrets from
`airflow.models` is deprecated."
+ "Please use `from airflow.sdk import Connection` instead",
+ DeprecationWarning,
+ stacklevel=1,
+ )
try:
conn = TaskSDKConnection.get(conn_id=conn_id)
if isinstance(conn, TaskSDKConnection):
