zach-overflow commented on code in PR #53397: URL: https://github.com/apache/airflow/pull/53397#discussion_r2222238142
########## airflow-core/docs/core-concepts/auth-manager/index.rst: ########## @@ -178,6 +180,8 @@ The following methods aren't required to override to have a functional Airflow a * ``batch_is_authorized_dag``: Batch version of ``is_authorized_dag``. If not overridden, it will call ``is_authorized_dag`` for every single item. * ``get_authorized_dag_ids``: Return the list of DAG IDs the user has access to. If not overridden, it will call ``is_authorized_dag`` for every single DAG available in the environment. + * Note: To filter the results of ``get_authorized_dag_ids``, it is recommended that you define the filtering logic in your ``filter_authorized_dag_ids`` method. For example, this may be usefule if you rely on per-DAG access controls derived from one or more fields on a given DAG (e.g. DAG tags). Review Comment: oof, my bad for missing this -- I completely forgot that I had left my pre-commit setup disabled while working on this 🤦♂️. Fixed this (and re-enabled pre-commit). Sorry for the added noise here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
