jason810496 commented on code in PR #53556: URL: https://github.com/apache/airflow/pull/53556#discussion_r2223016263
########## providers/redis/src/airflow/providers/redis/queues/redis.py: ########## @@ -0,0 +1,91 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import re +from typing import TYPE_CHECKING +from urllib.parse import urlparse + +from airflow.providers.common.messaging.providers.base_provider import BaseMessageQueueProvider +from airflow.providers.redis.triggers.redis_await_message import AwaitMessageTrigger + +if TYPE_CHECKING: + from airflow.triggers.base import BaseEventTrigger + +# [START queue_regexp] +QUEUE_REGEXP = r"^redis://" Review Comment: Would using `redis+pubsub` as the scheme be better for future flexibility? To offer some perspective from a Redis user’s point of view, there are at least three ways to use Redis as a queue: 1. Redis PubSub (the current implementation) 2. Redis Streams 3. The List data structure Although only PubSub is implemented for Redis Trigger at the moment, there _may_ be users who want to use Redis as a queue in different ways. I wanted to highlight the importance of flexibility for future integrations. Since we rely on documentation to specify the `QUEUE_REGEXP` for users, having either `redis://` or `redis+pubsub://` as the scheme should not pose any problems. cc @vincbeck, @potiuk WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
