gopidesupavan commented on code in PR #53332: URL: https://github.com/apache/airflow/pull/53332#discussion_r2223642741
########## task-sdk-tests/tests/task_sdk_tests/conftest.py: ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import os +import subprocess +import sys + +import pytest + +from task_sdk_tests.constants import AIRFLOW_ROOT_PATH, DOCKER_IMAGE + + [email protected] +def default_docker_image(): + return DOCKER_IMAGE + + [email protected](scope="session") +def install_task_sdk(): Review Comment: i think its better to use pytest test `pytest_sessionstart` hook, this way we can make sure our setup fully ready to run tests. otherwise install_task_sdk should be called on the first test that it starts running, when we add more tests and if any order changes pytest test execution it may cause some errors. https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest.hookspec.pytest_sessionstart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
