potiuk commented on code in PR #53149: URL: https://github.com/apache/airflow/pull/53149#discussion_r2224667207
########## shared/timezones/src/airflow_shared/timezones/timezone.py: ########## @@ -0,0 +1,318 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations Review Comment: That's a good point - the question is "where" it should live and which versions, because (eventually) different components migh have diffferent distributions installed. 1) On worker we are going to have only "apache-airlflow-task-sdk" installed (no "apache-airflow", no "apache-airflow-core") on day one of Airflow 3.1 (hopefully) 2) In other components (dag file processor, triggerer, and api-server if we want to continue installing providers there) - we will have both: * "apache-airflow-task-sdk" * "apache-airflow-core" 3) On scheduler and on the other hand only "apache-airflow-core" - no "apache-airflow-task-sdk" (not for now - this will only be possible if we separate executors from "regular" providers which might be next frontier of the separation) Theorethically of course - many people will just have "apache-airflow" installed and they will have "everything". So ... the queston is where the "utils" deprecation code should live. I think we do not need it in in "core" because we have full control over it and no legacy "user" code is allowed , so likely it could live in "task-sdk" - and "apache-airflow-providers-task-sdk" should also provide "airflow.utils" package with all deprecations (redirectiong to _shared libraries of task-sdk" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
