eladkal commented on code in PR #53666: URL: https://github.com/apache/airflow/pull/53666#discussion_r2225203171
########## devel-common/src/tests_common/test_utils/watcher.py: ########## @@ -16,10 +16,16 @@ # under the License. from __future__ import annotations -from airflow.decorators import task from airflow.exceptions import AirflowException from airflow.utils.trigger_rule import TriggerRule +from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS + +if AIRFLOW_V_3_0_PLUS: + from airflow.sdk import task +else: + from airflow.decorators import task # type: ignore[attr-defined,no-redef] Review Comment: But when we migrate specific part to SDK then we migrate also the imports. don't we? I guess my question is how did this come up separately than the PR who migrated the code ########## devel-common/src/tests_common/test_utils/watcher.py: ########## @@ -16,10 +16,16 @@ # under the License. from __future__ import annotations -from airflow.decorators import task from airflow.exceptions import AirflowException from airflow.utils.trigger_rule import TriggerRule +from tests_common.test_utils.version_compat import AIRFLOW_V_3_0_PLUS + +if AIRFLOW_V_3_0_PLUS: + from airflow.sdk import task +else: + from airflow.decorators import task # type: ignore[attr-defined,no-redef] Review Comment: But when we migrate specific part to SDK then we migrate also the imports. don't we? I guess my question is how did this come up separately from the PR who migrated the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
