nrnavaneet commented on PR #53669:
URL: https://github.com/apache/airflow/pull/53669#issuecomment-3108174918

   Well, I'm not a member, but LGTM. Maybe consider adding a test in  
   `providers/standard/tests/unit/standard/sensors/test_time.py` if the 
maintainers think it's needed, :
   
   ```python
       def test_execute_complete_accepts_event_argument(self):
           """Ensure execute_complete supports the 'event' kwarg when 
deferrable=True."""
           with DAG(
               dag_id="test_execute_complete_event",
               schedule=None,
               start_date=datetime(2020, 1, 1),
           ):
               op = TimeSensor(task_id="test", target_time=time(10, 0), 
deferrable=True)
   
           try:
               op.execute_complete(context={}, event={"status": "success"})
           except TypeError as e:
               pytest.fail(f"execute_complete raised TypeError unexpectedly: 
{e}")


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to