cmarteepants commented on PR #53035:
URL: https://github.com/apache/airflow/pull/53035#issuecomment-3109481902
Big đ for getting core HITL UI in! This will unblock 3.1. Jens did the heavy
lifting with the review, and I see a lot of his points are already addressed!!
Some additional feedback:
**User-facing label**
âHITLâ and even âHuman Tasksâ describe the implementation, not the userâs
job. Most approvers just need to know that something is blocking a run and
needs their attention. I suggest renaming all UI surfaces to âAction Requiredâ
(top nav, tabs). Per-row status chips can then show the specific need: Approval
needed, Input needed, Choice needed, etc.
This is clearer to end-users, covers every HITL use case, and fits in the
nav without wrapping. Iâm happy to help map the i18n string keys if that helps.
**Additional UX tweaks**
1. Hide empty tabs everywhere: Extend the existing âhide when emptyâ logic
from the DAG page to DAG Run, Task, and Task-Instance pages.
2. Inline response buttons: Current flow (dropdown â Respond) takes two
clicks and is awkward to navigate.
- Pattern:
- If the option set ⤠4: render each option as a button.
- If > 4: keep the dropdown, but submit immediately when a value is
chosen (remove the extra Respond button).
- Benefits: faster, more accessible, eliminates the overflow glitch.
3. Persist and show responses + log them
- Store the chosen option with user and timestamp.
- Show the saved choice when the dialog is reopened (âResponded âApproveâ
by Alice at 14:02â).
- Write the same info to task and audit logs for an immutable trail and
easier debugging.
Let me know if any of these need more detail and I can open a follow-up
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
