sjyangkevin commented on code in PR #53690:
URL: https://github.com/apache/airflow/pull/53690#discussion_r2227675174
##########
airflow-core/src/airflow/serialization/serializers/numpy.py:
##########
@@ -31,11 +31,12 @@
"numpy.uint16",
"numpy.uint32",
"numpy.uint64",
- "numpy.bool_",
"numpy.float64",
"numpy.float16",
"numpy.complex128",
"numpy.complex64",
+ "numpy.bool",
Review Comment:
I think the test failure is related to this list.
airflow-core/tests/unit/serialization/test_serde.py:409: in
test_serializers_importable_and_str
import_string(s)
at runtime it is lazy loading. If the installed NumPy is 1.x, it can load
the `numpy.bool_`. If the installed NumPy is 2.x, it can load the `numpy.bool`.
However, the test tries to load all the types here, and if we are on 1.x, then
`numpy.bool` is considered deprecated and couldn’t be loaded, hence the test
failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
