gopidesupavan opened a new pull request, #53718:
URL: https://github.com/apache/airflow/pull/53718

   closes https://github.com/apache/airflow/issues/51005
   
   When task killed externally the task process getting terminated immediately  
and no way to trigger on_kill functionality.
   
   Registered on_kill to signal , this way when sigterm requested , this will 
trigger on_kill.
   
   I dont have any other ideas to make it work. feel free to suggest if any 
other options available 
   
   before:
   
   <img width="1353" height="541" alt="image" 
src="https://github.com/user-attachments/assets/88a449aa-e346-4a70-8cd2-aa4d7a1e044b";
 />
   
   after:
   
   <img width="1369" height="506" alt="image" 
src="https://github.com/user-attachments/assets/46ce4ea5-2091-4d75-a72a-8d96b7a02d45";
 />
   
   
   example dag:
   
   ```
   
   from time import sleep
   from typing import TYPE_CHECKING
   
   from airflow.sdk import BaseOperator
   import time
   from airflow.sdk.definitions.context import Context
   
   
   class CustomOperator(BaseOperator):
       def __init__(self, **kwargs) -> None:
           super().__init__(**kwargs)
   
       def pre_execute(self, context):
           print("pre Execute!")
   
       def execute(self, context: Context):
           for i in range(10):
               print(f"Iteration {i}: Sleeping for 20 seconds...")
               time.sleep(20)
   
       def on_kill(self) -> None:
           self.log.info("on_kill called!")
   
   import os
   from datetime import timedelta
   from airflow.sdk import DAG
   
   
   with DAG(
       dag_id="check_on_kill",
       schedule=None,
       catchup=False,
   ) as dag:
       test_on_kill_hook = CustomOperator(
           task_id="test_on_kill_hook",
       )
   
       test_on_kill_hook
   
   
   
   ```
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to