mik-laj commented on a change in pull request #6496: [AIRFLOW-5704] Improve
Kind Kubernetes scripts for local testing. Depends on [AIRFLOW-5830]
[AIRFLOW-5829]
URL: https://github.com/apache/airflow/pull/6496#discussion_r343026242
##########
File path:
scripts/ci/in_container/kubernetes/setup_kubernetes_and_deploy_app.sh
##########
@@ -14,12 +15,12 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-ARG AIRFLOW_CI_IMAGE
-FROM ${AIRFLOW_CI_IMAGE}
-COPY airflow-test-env-init.sh /tmp/airflow-test-env-init.sh
+set -euo pipefail
+MY_DIR=$(cd "$(dirname "$0")" && pwd)
-COPY bootstrap.sh /bootstrap.sh
-RUN chmod +x /bootstrap.sh
-
-ENTRYPOINT ["/bootstrap.sh"]
+echo
+echo "Set up Kubernetes cluster for tests"
Review comment:
Are you sure you need this file? This file is used in only one place and
does not contain complicated logic. Can you make it inline? This will reduce
the number of files and make it easier to understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
